Skip to content

feat(binder): implement Binder::bind_expr#28

Merged
KKould merged 3 commits intoKipData:mainfrom
KKould:main
Jul 28, 2023
Merged

feat(binder): implement Binder::bind_expr#28
KKould merged 3 commits intoKipData:mainfrom
KKould:main

Conversation

@KKould
Copy link
Copy Markdown
Member

@KKould KKould commented Jul 26, 2023

What problem does this PR solve?

Add corresponding issue link with summary if exists -->

Issue link:

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Jul 26, 2023
@KKould KKould added the enhancement New feature or request label Jul 26, 2023
@KKould KKould linked an issue Jul 26, 2023 that may be closed by this pull request
13 tasks
@KKould KKould added this to the v0.1 milestone Jul 26, 2023
Copy link
Copy Markdown
Member

@loloxwg loloxwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KKould KKould merged commit e9ad922 into KipData:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

binder

2 participants